readline: use native codePointAt
#825
Conversation
| @@ -1331,7 +1331,8 @@ function codePointAt(str, index) { | |||
| } | |||
| return code; | |||
| } | |||
| exports.codePointAt = codePointAt; | |||
| exports.codePointAt = util.deprecate(codePointAt, | |||
| 'codePointAt() is deprecated. Use String.prototype.codePointAt'); | |||
There was a problem hiding this comment.
Instead of deprecating it, could we just alias it to Function.prototype.call.bind(String.prototype.codePointAt) and note that it's there for legacy reasons in the docs?
There was a problem hiding this comment.
it is actually undocumented and is not supposed to be used anyway. Unfortunately we have a lot of private not underscored stuff
There was a problem hiding this comment.
If it's undocumented, isn't is subject to disappearing at any time? (I realize someone could be using it)
There was a problem hiding this comment.
FWIW, I agree with @vkurchatkin. I believe the reason it was exported was so it could be unit-tested in the test suite.
There was a problem hiding this comment.
I guess that would a bit irresponsible. People use repl to discover stuff. We need a roadmap to avoid these in the future
There was a problem hiding this comment.
Yes people use the repl and other reads the code to find and use undocumented apis. I've done it myself, but I do not expect that code to work between versions.
|
@chrisdickinson ping |
Semver: patch PR-URL: #825 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
LGTM. Merged in b41dbc2. |
R=have no idea