Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't abort when c-ares initialization fails #8710

Merged
merged 1 commit into from
Sep 23, 2016
Merged

src: don't abort when c-ares initialization fails #8710

merged 1 commit into from
Sep 23, 2016

Commits on Sep 23, 2016

  1. src: don't abort when c-ares initialization fails 

    Throw a JS exception instead of aborting so the user at least has a
fighting chance of understanding what went wrong.

Fixes: nodejs#8699
PR-URL: nodejs#8710
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
    @bnoordhuis
    bnoordhuis committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    5cb5b1f View commit details
    Browse the repository at this point in the history