internal: fix TypeError in v8-polyfill

[geek]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

v8 profile processor

Description of change

readline() can return a boolean, in which case, line 90 will throw an exception. This change addresses the issue by defaulting to a string in readline() instead of returning false.

[jasnell]

LGTM

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/4336/

[bnoordhuis]

I'd change the return false in readline() to return '', that way future call sites won't run into the same issue.

If other collaborators think this is fine though, I'm fine with it too.

[geek]

@bnoordhuis fixed

[bnoordhuis]

CI: https://ci.nodejs.org/job/node-test-pull-request/4391/

[geek]

This was the failure on AIX

https://ci.nodejs.org/job/node-test-commit-aix/1300/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1219 pseudo-tty/test-tty-wrap

I reran the job and it succeeded:

https://ci.nodejs.org/job/node-test-commit-aix/1305/

[jasnell]

Landed in 47d1588

[MylesBorins]

added lts watch as this lands on v4.x let me know if it should not land

[jasnell]

there's likely no harm in landing it.