Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor typo in CHANGELOG.md #902

Merged
merged 1 commit into from
Feb 20, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 20, 2015

@rvagg rvagg force-pushed the changelog-process-progress-derp branch 2 times, most recently from 9164435 to 472c291 Compare February 20, 2015 09:36
@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

updated to include the cipher suite changes notes by @silverwind also

@silverwind
Copy link
Contributor

First line is fine, second should be:

Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion

@rvagg rvagg force-pushed the changelog-process-progress-derp branch from 472c291 to da87915 Compare February 20, 2015 09:42
@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

@silverwind changed, ptal

@silverwind
Copy link
Contributor

LGTM

PR-URL: nodejs#902
Reviewed-By: Roman Reiss <me@silverwind.io>
@rvagg rvagg force-pushed the changelog-process-progress-derp branch from da87915 to 0ac5731 Compare February 20, 2015 09:44
@rvagg rvagg merged commit 0ac5731 into nodejs:v1.x Feb 20, 2015
@rvagg rvagg deleted the changelog-process-progress-derp branch February 20, 2015 09:45
@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2015

ta muchly!

This was referenced Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants