Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: name anonymous functions in https #9217

Closed
wants to merge 3 commits into from
Closed

https: name anonymous functions in https #9217

wants to merge 3 commits into from

Conversation

pvsousalima
Copy link
Contributor

@pvsousalima pvsousalima commented Oct 21, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

https

Description of change

https: name anonymous functions in https

name anonymous functions in https module
the changes are related to commits ef030da and accf410
which are naming anonymous functions to standardize the code
and help debugging, also with Ref: #8913

@nodejs-github-bot nodejs-github-bot added the https Issues or PRs related to the https subsystem. label Oct 21, 2016
@targos
Copy link
Member

targos commented Oct 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4631/

@pvsousalima pvsousalima mentioned this pull request Oct 24, 2016
Closed
2 tasks
@lpinca
Copy link
Member

lpinca commented Oct 25, 2016

I think that it is fine (but not necessary?) to also name prototype functions. Still LGTM.

@pvsousalima
https: name anonymous functions in https
156b70a 
related to commit ef030da
which is naming anonymous functions to standardize the code
@pvsousalima
https: name anonymous functions
fd487fa 
As stated in #9252 anonymous callback functions should
be named, but not functions that are assigned to a property
on a variable because the name is inferred from the assignment
@pvsousalima
https: name anonymous functions in https
3d00f17 
related to commit ef030da
which is naming anonymous functions to standardize the code
@italoacasas
Copy link
Contributor

Landed in: 1f45d7a

Thanks for the contribution.

italoacasas pushed a commit that referenced this pull request Nov 25, 2016
@pvsousalima @italoacasas
https: name anonymous functions in https
1f45d7a 
Naming anonymous function in the https module

PR-URL: #9217
Ref: #8913
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@pvsousalima @addaleax
https: name anonymous functions in https
9554a97 
Naming anonymous function in the https module

PR-URL: #9217
Ref: #8913
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pvsousalima @targos @lpinca @italoacasas @jasnell @MylesBorins @nodejs-github-bot