Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix freebsd10-64 CI failures #9317

Closed
wants to merge 3 commits into from
Closed

test: fix freebsd10-64 CI failures #9317

wants to merge 3 commits into from

Commits on Oct 29, 2016

  1. test: fix freebsd10-64 CI failures 

    Remove unneeded timers from some tests and move others from parallel
testing to sequential testing.

This is to resolve test failures on freebsd10-64 on CI. The failures
are all due to timers firing later than expected. Timers firing later
than they are set for can happen on resource-constrained hosts and is
not a bug.

In general, it may be wise to put tests that depend on timing into
sequential testing rather than parallel testing, as the timing can
be affected by other simultaneously-running test processes.

Fixes: nodejs#8041
Fixes: nodejs#9227
    @Trott
    Trott committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    8efee55 View commit details
    Browse the repository at this point in the history

  2. squash: remove another timer

    @Trott
    Trott committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    23cecf7 View commit details
    Browse the repository at this point in the history

  3. squash: common.mustCall()

    @Trott
    Trott committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    571a612 View commit details
    Browse the repository at this point in the history