Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cares: sync with upstream, fully adopt v1.12.0 #9332

Closed
wants to merge 7 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 28, 2016

Not a big change but previous sync's have been piecemeal so this is a full job. I've also redone most of the config headers in config/ (haven't touched the AIX one but it still compiles and passes).

Passing CI @ https://ci.nodejs.org/job/node-test-commit/5830/ minus unrelated freebsd failures.

I believe this is ABI and API stable so could be backported through to v4.x.

@mscdex mscdex added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Oct 28, 2016
@rvagg
Copy link
Member Author

rvagg commented Oct 28, 2016

@indutny @bnoordhuis I think you two might be best equipped to review this one

@sam-github
Copy link
Contributor

@rvagg @richardlau should the AIX header be updated, too, or is it just cosmetic?

@gibfahn
Copy link
Member

gibfahn commented Oct 28, 2016

cc/ @nodejs/platform-aix

@richardlau
Copy link
Member

Looking at the changes to the config/ headers for the other platforms in this pull request I think the AIX header should be updated too.

@rvagg Looks like this change also adds deps/cares/LICENSE.md -- Presumably we want to update the license-builder.sh script to use this file and regenerate the license?

@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2016

updated license-builder.sh, thanks @richardlau, that's why I included LICENSE.md after all!

@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2016

I've updated AIX config, I had trouble getting access to an AIX machine yesterday but I've figured out my problem. PTAL IBMers.

@gibfahn
Copy link
Member

gibfahn commented Oct 29, 2016

@jasnell
Copy link
Member

jasnell commented Mar 24, 2017

Ping... updates?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 24, 2017
@gibfahn
Copy link
Member

gibfahn commented Mar 24, 2017

cc/ @nodejs/platform-aix regarding the AIX header update.

@fhinkel
Copy link
Member

fhinkel commented May 26, 2017

@rvagg Any idea if the CI failures are related? Is this ready to land?

@mscdex
Copy link
Contributor

mscdex commented Jun 24, 2017

c-ares 1.13.0 is available now. If we can land that instead, that will also take care of #13897 in the process.

@kasicka
Copy link

kasicka commented Jun 27, 2017

Is there any ETA on this?

@BridgeAR
Copy link
Member

@rvagg are you going to follow up on this?

@BridgeAR
Copy link
Member

Closing this due to a long inactivity. Please feel free to reopen if you want to follow up on this @rvagg

@BridgeAR BridgeAR closed this Sep 12, 2017
@rvagg
Copy link
Member Author

rvagg commented Sep 13, 2017

Thanks for the nudge @BridgeAR! Sorry for my unresponsiveness here, I'm trying to get back on the 🐴 now. Opened at new PR @ #15378 with 1.13.0 but it still has a couple of failures. Any additional help there would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. stalled Issues and PRs that are stalled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.