Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: os properties functions return types #9648

Closed
wants to merge 1 commit into from
Closed

doc: os properties functions return types #9648

wants to merge 1 commit into from

Conversation

imatveev
Copy link
Contributor

@imatveev imatveev commented Nov 16, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added data types of functions returns and static props.
Issue

@nodejs-github-bot nodejs-github-bot added dont-land-on-v7.x doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Nov 16, 2016
@imatveev imatveev mentioned this pull request Nov 16, 2016
Closed
@imatveev imatveev changed the title Doc os properties functions return types doc: os properties functions return types Nov 16, 2016
@imatveev imatveev force-pushed the doc-OS-properties-functions-return-types branch from 436a94b to 027842f Compare November 16, 2016 20:53
@Fishrock123 Fishrock123 mentioned this pull request Nov 16, 2016
Merged
Fishrock123 added a commit to Fishrock123/github-bot that referenced this pull request Nov 16, 2016
@Fishrock123
attempt-backport: disable for now
015096f 
Refs: nodejs#90

See also:
nodejs/node#9637
nodejs/node#9472
nodejs/node#9648
mhdawson
mhdawson approved these changes Nov 17, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/4868/

@imatveev
Copy link
Contributor Author

@mhdawson what is the reason?

@silverwind
Copy link
Contributor

Thanks! Landed in f9c9856.

@silverwind silverwind closed this Nov 18, 2016
silverwind pushed a commit that referenced this pull request Nov 18, 2016
@imatveev @silverwind
doc: add return types and props types to OS module
f9c9856 
PR-URL: #9648
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@imatveev @addaleax
doc: add return types and props types to OS module
b258a70 
PR-URL: #9648
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@imatveev imatveev deleted the doc-OS-properties-functions-return-types branch December 15, 2016 22:26
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@imatveev @MylesBorins
doc: add return types and props types to OS module
acebfed 
PR-URL: #9648
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@imatveev @MylesBorins
doc: add return types and props types to OS module
40e4f0d 
PR-URL: #9648
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@princejwesley princejwesley princejwesley approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@imatveev @mhdawson @silverwind @jasnell @lpinca @princejwesley @cjihrig @MylesBorins @Fishrock123 @nodejs-github-bot