Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: crypto-hash-stream-pipe use strict equal #9935

Conversation

mitchellst
Copy link
Contributor

Checklist
  • [ x] make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • [x ] commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Replaces the use of assert.equal() with assert.strictEqual in test
code.

Replaces the use of assert.equal() with assert.strictEqual in test
code.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. labels Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: nodejs#9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 1a83b19. Thanks for the contribution! 🎉

@Trott Trott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: #9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: nodejs#9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: nodejs#9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Replaces the use of assert.equal() with assert.strictEqual in test
code.

PR-URL: #9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants