Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change assert.equal to assert.strictEqual in parallel/test-cluster-setup-argv.js #9993

Closed
wants to merge 1 commit into from

Conversation

ctsuei
Copy link

@ctsuei ctsuei commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

Description of change

Update equal assertion in parallel/test-cluster-setup-master-argv.js to strict equal.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. cluster Issues and PRs related to the cluster subsystem. labels Dec 1, 2016
@ctsuei ctsuei changed the title test: update equal assertion to strict test: update equal assertion to strict in parallel/test-cluster-setup-argv.js Dec 1, 2016
@ctsuei ctsuei changed the title test: update equal assertion to strict in parallel/test-cluster-setup-argv.js test: change assert.equal to assert.strictEqual in parallel/test-cluster-setup-argv.js Dec 1, 2016
Update file parallel/test-cluster-setup-master-argv.js equal compare assertion to strict.
This will ensure the compare is matching the type as well.
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ✅

@Trott
Copy link
Member

Trott commented Dec 4, 2016

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
Change assert.equal to assert.strictEqual.

PR-URL: nodejs#9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 3f19733. Thanks for the contribution! 🎉

@Trott Trott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Change assert.equal to assert.strictEqual.

PR-URL: #9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Change assert.equal to assert.strictEqual.

PR-URL: nodejs#9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Change assert.equal to assert.strictEqual.

PR-URL: nodejs#9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Change assert.equal to assert.strictEqual.

PR-URL: #9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Change assert.equal to assert.strictEqual.

PR-URL: #9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Change assert.equal to assert.strictEqual.

PR-URL: #9993
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants