Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML rendering on Docs index page #1820

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Fix HTML rendering on Docs index page #1820

merged 1 commit into from
Sep 24, 2018

Conversation

pboivin
Copy link
Contributor

@pboivin pboivin commented Sep 24, 2018

Hi!

This pull request is for a small fix to the 'Docs' index page:
https://nodejs.org/en/docs/

In section 'Looking for API docs of previous releases?', the block of links is currently rendered as plain text instead of HTML.

This fix changes the level of indentation of the HTML snippet within the Markdown document, from 4 spaces to 2 spaces.

Before:

before

After:

after

Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems to be related to the metalsmith-markdown update.
(Wow, why would indentation change the rendering of HTML at all?!)

@fhemberger fhemberger merged commit 23b501e into nodejs:master Sep 24, 2018
@fhemberger
Copy link
Contributor

Published. Thank you!

@pboivin
Copy link
Contributor Author

pboivin commented Sep 24, 2018

Beats me. I have grepped around the docs/ folder to compare with other HTML snippets and couldn't find any other with an indentation of 4 spaces...

Thanks for the quick reply :)

@vsemozhetbyt
Copy link
Contributor

(Wow, why would indentation change the rendering of HTML at all?!)

Seems per spec:

To produce a code block in Markdown, simply indent every line of the block by at least 4 spaces or 1 tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants