fixture: add the process of throwing exceptions #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) When there's something wrong in 'fs.readdir' in either 'server.js' or 'build.js', this is an async callback, so we should throw exceptions immediately to stop the futher process to let users know what mistakes they may have made. 2) Change the Log info for 'add' and 'change' for file watching.
SEWeiTung
requested review from
alexandrtovmach
and removed request for
alexandrtovmach
XhmikosR
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's something wrong in 'fs.readdir' in either 'server.js' or 'build.js', this is an async callback, so we should throw exceptions immediately to stop the futher process to let users know what mistakes they may have made.
Change the Log info for 'add' and 'change' for file watching.