Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra semicolons. #2484

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Remove extra semicolons. #2484

merged 1 commit into from
Sep 3, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 2, 2019 •
edited by SEWeiTung
Loading

'build.js' has extra semicolons, remove them together.

@Trott
Copy link
Member

Trott commented Sep 2, 2019

standard --fix which runs on npm t doesn't fail if it can fix the issues. This is another reason to separate the npm scripts...

Wand to include the fix to package.json here as a second commit so that more things like this don't creep in?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 2, 2019

@Trott I believe this should be handled in a separate PR, see #2463. It's already pretty troublesome developing, let alone that we have npm t in a precommit hook which slows down things a lot...

@SEWeiTung SEWeiTung merged commit 4936031 into nodejs:master Sep 3, 2019
@XhmikosR XhmikosR deleted the xmr-semi branch September 3, 2019 04:38
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @Trott @SEWeiTung