Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split npm scripts and run them in parallel #2504

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Split npm scripts and run them in parallel #2504

merged 2 commits into from
Sep 8, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 5, 2019

This is a first approach at addressing #2463.

Other changes:

  1. removed --fix from standard because on CI this didn't make the build fail. One can still do npm run test:lint:js -- --fix locally if they want to
  2. runs test:lint scripts in parallel

I still think we should move npm run build outside of tape and just run this before test. Build warnings aren't shown in tape

Fixes #2463

@XhmikosR XhmikosR changed the title Split npm scripts and run lint them in parallel Split npm scripts and run them in parallel Sep 5, 2019
@XhmikosR XhmikosR marked this pull request as ready for review September 6, 2019 05:59
@SEWeiTung SEWeiTung self-requested a review September 7, 2019 13:19
@Trott
Copy link
Member

Trott commented Sep 7, 2019

Seems fine to me.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 7, 2019

@Trott how about moving build in scripts and not in tape? See #2442 (comment)

@Trott
Copy link
Member

Trott commented Sep 8, 2019

@Trott how about moving build in scripts and not in tape? See #2442 (comment)

👍

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 8, 2019

Cool, I'll make this change in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split npm test scripts
3 participants