Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap security so it respects Node.js linter #2610

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Wrap security so it respects Node.js linter #2610

merged 3 commits into from
Sep 27, 2019

Conversation

sam-github
Copy link
Contributor

It doesn't matter here, but to keep this file textually identical to the
policy in Node.js, the markdown needs to lint clean.

See: nodejs/node#29682

It doesn't matter here, but to keep this file textually identical to the
policy in Node.js, the markdown needs to lint clean.

See: nodejs/node#29682
@Aissaoui-Ahmed Aissaoui-Ahmed requested review from yous and reedloden and removed request for yous September 26, 2019 22:48
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small non-blocking nits.

locale/en/security.md Outdated Show resolved Hide resolved
locale/en/security.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Sep 26, 2019

It doesn't matter here, but to keep this file textually identical to the
policy in Node.js, the markdown needs to lint clean.

See: nodejs/node#29682

FWIW, I think the plan is to eventually have the same markdown linting rules in both repositories, so this is a good thing to do now.

sam-github and others added 2 commits September 26, 2019 16:03
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants