Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metalsmith-yearly-pagination to v4.0.0. #2614

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Update metalsmith-yearly-pagination to v4.0.0. #2614

merged 1 commit into from
Sep 28, 2019

Conversation

XhmikosR
Copy link
Contributor

Fixes #2422

/CC @phillipj

@phillipj
Copy link
Member

LGTM

Refs phillipj/metalsmith-yearly-pagination#9

@XhmikosR
Copy link
Contributor Author

Don't forget to approve and merge, not sure what's the policy about the required approvals :)

@XhmikosR XhmikosR mentioned this pull request Sep 28, 2019
@phillipj
Copy link
Member

Personally a fan of leaving some room for any kind of questions/objections to be raised (as described in ./COLLABORATOR_GUIDE.md), even when it seems extremely trivial, it's a collaborative effort after all.

@XhmikosR
Copy link
Contributor Author

NP, I just feel like some of my PRs could have been merged sooner, that is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong path when there's no previous yearly archive
3 participants