Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node.js -> Node.js #2657

Merged
merged 5 commits into from
Oct 10, 2019
Merged

fix: node.js -> Node.js #2657

merged 5 commits into from
Oct 10, 2019

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Oct 9, 2019

Manually reviewed since casing is intended for emails and some urls.

Manually reviewed since casing is intended for emails and some urls.
@Trott
Copy link
Member

Trott commented Oct 9, 2019

@nodejs/website

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Trott
Trott previously requested changes Oct 10, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed per comments. (Not sure about all of them, but some of them are definitely required.) Feel free to dismiss this "request changes" review once changes have been applied.

Co-Authored-By: Aissaoui Ahmed <Aissaoui-Ahmed@users.noreply.github.com>
@nschonni nschonni requested a review from Trott October 10, 2019 04:56
@Trott Trott dismissed their stale review October 10, 2019 05:34

changes applied

Copy link
Contributor

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XhmikosR
Copy link
Contributor

BTW I wouldn't remove the double spaces after a period in this PR.

It seems it is in many places; I believe some people prefer writing like that. Personally I don't agree with that, but still, it should be done in a separate PR and tackle all of the instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.