Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add meeting notes 2023-02-20 (#58) #61

Merged
merged 4 commits into from
Feb 22, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions meetings/2023-02-20.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Node.js Performance Team Meeting 2023-02-20

## Links

* **Recording**: https://www.youtube.com/watch?v=KLsxXja1fYs
* **GitHub Issue**: https://github.com/nodejs/performance/issues/58

## Present

* Performance team: @nodejs/performance
* Yagiz Nizipli: @anonrig
* Ulises Gascon: @ulisesGascon
* Santiago Gimeno: @santigimeno
* Juan Arboleda: @soyjuanarbol

UlisesGascon marked this conversation as resolved.
Show resolved Hide resolved

## Agenda

## Announcements

- The new URL parser will be released this week!
UlisesGascon marked this conversation as resolved.
Show resolved Hide resolved
- It was a productive week for all of us! Other improvements had been made by the group members (Ruben, Joyee and multiple other collaborators) based on separated issues
- Santiago is planning to do a new PR for event creation this week

*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/performance

* getLibuvNow is slow [#49](https://github.com/nodejs/performance/issues/49)
- Seems that there is a fix for it, related to timers (https://github.com/nodejs/node/pull/46579) with v8 fastApi. (Thanks to joyee!)
It will be removed from the agenda
UlisesGascon marked this conversation as resolved.
Show resolved Hide resolved
* AbortSignal pattern is slow [#44](https://github.com/nodejs/performance/issues/44)
- Ruben created a PR to reduce error creation duration by 86-166% (Amazing work!)
- There are several issues with AbortSignal Pattern
- Emitting events is slow (Santiago will open a PR to improve this)
- Adding and removing event listeners in event Targets. This is actually the main issue. New issue: https://github.com/nodejs/performance/issues/60
- We have specific perf benchmarks for events (adding and removing) in https://github.com/nodejs/node/blob/main/benchmark/events/eventtarget.js, seems like we should potentially update them for EventTarget addition/removal.
* Module resolution [#39](https://github.com/nodejs/performance/issues/39)
- Yagiz did some research and a PR related to it (https://github.com/nodejs/node/pull/46652) - Not yet merged. We should add a caching layer once is merged
- There is a pending PR for changing off threading loaders. Until it gets merged, Yagiz’s pull request will be on hold to avoid git conflicts.
* WHATWG Streams [#9](https://github.com/nodejs/performance/issues/9)
- There is an option to improve this by moving the core logic to C++, similar to the work done by Deno and Bun, but requires extensive work. For the time being, we can close this issue.
- This item will be removed from the agenda

## Q&A, Other
- Yagiz opened several PRs related to URL parsing and he discovered a happy path that has a more performing approach. There was a discussion around it with Daniel as this implementation may have a more complex implementation as hidden cost. It is an early stage yet to build a consensus.

## Upcoming Meetings

* **Node.js Foundation Calendar**: https://nodejs.org/calendar

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.