Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect when missing trailing slash #28

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix: redirect when missing trailing slash #28

merged 2 commits into from
Sep 27, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 27, 2023

Fixes: #25

@MoLow MoLow requested a review from a team as a code owner September 27, 2023 13:50
ovflowd
ovflowd reviewed Sep 27, 2023
View reviewed changes
src/handlers/get.ts Outdated Show resolved Hide resolved
ovflowd
ovflowd approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I left a comment due to some concerns

@MoLow MoLow merged commit 808c8d2 into main Sep 27, 2023
3 checks passed
@flakey5 flakey5 deleted the add-trailing-slash branch October 20, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to redirect to trailing slash when serving index.html
2 participants
@MoLow @ovflowd