refactor: code cleanup and handlebars template #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @MoLow this is giving 5XX errors, but I have no idea why... |
MoLow
reviewed
Sep 27, 2023
MoLow
approved these changes
Sep 27, 2023
|
@MoLow could you test this locally with |
ovflowd
force-pushed
the
refactor/code-cleanup
branch
from
f9dfb2a
to
6b0f0f0
Compare
Without testing locally, my guess would be that handlebars generates code which is not allowed in cloudflare workers. |
ovflowd
force-pushed
the
refactor/code-cleanup
branch
from
50d3038
to
3897075
Compare
Indeed. I didn't know that |
flakey5
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some code cleanup (standard conventions, code readability, adds
todostatements and does minor code stylistic updates, renamed some files)This PR introduces
handlebarsfor the template engine for the directory listingThis PR updates some of the packages.