Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: simplify Object.prototype accessor preventions #1886

Closed
wants to merge 1 commit into from

Conversation

KhafraDev
Copy link
Member

Creating a null prototype object works better than listing out each property!

Still some issues with TransformStreams because of nodejs/node#46355 (for a while I thought this was an undici issue, but it isn't).

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Base: 90.33% // Head: 94.94% // Increases project coverage by +4.60% 🎉

Coverage data is based on head (b98a458) compared to base (f02ab5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
+ Coverage   90.33%   94.94%   +4.60%     
==========================================
  Files          70       39      -31     
  Lines        6045     2888    -3157     
==========================================
- Hits         5461     2742    -2719     
+ Misses        584      146     -438     
Impacted Files Coverage Δ
index.js 74.48% <0.00%> (-24.49%) ⬇️
lib/core/util.js 88.27% <0.00%> (-9.66%) ⬇️
lib/api/readable.js 82.75% <0.00%> (-8.63%) ⬇️
lib/handler/RedirectHandler.js 87.50% <0.00%> (-7.50%) ⬇️
lib/mock/mock-utils.js 93.95% <0.00%> (-6.05%) ⬇️
lib/proxy-agent.js 88.31% <0.00%> (-5.20%) ⬇️
lib/core/request.js 94.25% <0.00%> (-4.60%) ⬇️
lib/fetch/body.js
lib/fetch/index.js
lib/fetch/constants.js
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KhafraDev KhafraDev closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants