fix: post request signal #3354
Merged
fix: post request signal #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gigioliva
commented
Jun 21, 2024
| @@ -36,9 +36,11 @@ test('post abort signal', async (t) => { | |||
|
|
|||
| server.listen(0, async () => { | |||
| const ac = new AbortController() | |||
| const ures = await request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal }) | |||
| const uresPromise = request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal }) | |||
There was a problem hiding this comment.
ℹ️ this test was wrong because request api terminates when the stream has been completely consumed, so the connection has been closed. If we postpone the await we can throw the abort before dispatch starts consuming the stream, so the request is actually aborted
Gigioliva
commented
Jun 21, 2024
Comment on lines
+92
to
+94
| const ures = await request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal }) | ||
| ac.abort() | ||
| t.equal(await ures.body.text(), 'asd') |
There was a problem hiding this comment.
ℹ️ in this case the abort signal is ignored since the request is completed
There was a problem hiding this comment.
Since these are modeled after the fetch body mixins, I'm wondering if they should throw. In the fetch spec, if a request was aborted and you attempt to read the body, it'll throw an error. @ronag wdyt?
Uzlopak
approved these changes
Jun 21, 2024
ronag
approved these changes
Jun 22, 2024
mcollina
pushed a commit
that referenced
this pull request
Jun 22, 2024
ronag
added a commit
to nxtedition/undici
that referenced
this pull request
Jun 25, 2024
* upstream/main: fix: use explicit flag for when use has interacted with stream (nodejs#3361) refactor: simplify signal handling (nodejs#3362) fix: consider bytes read when dumping (nodejs#3360) websocket: don't use pooled buffer in mask pool (nodejs#3357) Revert "fix: post request signal (nodejs#3354)" (nodejs#3359) fix: post request signal (nodejs#3354) build(deps): bump node from `075a5cc` to `9af472b` in /build (nodejs#3355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix post request abort signal
Fix issue #3353
Rationale
Request API doesn't remove the signal listener after complete the request
Changes
Remove abort listener after success
Status