Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): toUSVString #986

Merged
merged 4 commits into from
Aug 20, 2021
Merged

fix(fetch): toUSVString #986

merged 4 commits into from
Aug 20, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 18, 2021

No description provided.

@ronag ronag requested a review from mcollina August 18, 2021 20:15
lib/fetch/util.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #986 (1169e94) into main (b7ee4b3) will increase coverage by 3.08%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   90.80%   93.88%   +3.08%     
==========================================
  Files          37       37              
  Lines        3587     3614      +27     
==========================================
+ Hits         3257     3393     +136     
+ Misses        330      221     -109     
Impacted Files Coverage Δ
lib/fetch/formdata.js 84.09% <90.90%> (+44.85%) ⬆️
lib/api/readable.js 86.11% <100.00%> (ø)
lib/fetch/body.js 99.15% <100.00%> (+<0.01%) ⬆️
lib/fetch/request.js 81.70% <100.00%> (+18.29%) ⬆️
lib/fetch/response.js 90.15% <100.00%> (+10.60%) ⬆️
lib/fetch/util.js 85.71% <100.00%> (+3.74%) ⬆️
lib/fetch/headers.js 92.81% <0.00%> (+11.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ee4b3...1169e94. Read the comment docs.

@mcollina
Copy link
Member

I don't understand what this brings.

@ronag
Copy link
Member Author

ronag commented Aug 19, 2021

I don't understand what this brings.

Placeholder for spec compliance. The spec says that these should be "usvstring"s. We need to eventually either implement _toUSVString ourselves or have node core expose it.

@ronag
Copy link
Member Author

ronag commented Aug 19, 2021

We do the same thing for the URL module in node core.

@mcollina
Copy link
Member

Awesome, ok. Let's expose this from core.

ronag added a commit to nxtedition/node that referenced this pull request Aug 19, 2021
Expose toUSVString to it can be used by user libraries.

Refs: nodejs/undici#986
ronag added a commit to nxtedition/node that referenced this pull request Aug 19, 2021
Expose toUSVString to it can be used by user libraries.

Refs: nodejs/undici#986
@ronag ronag merged commit 31de23e into main Aug 20, 2021
lpinca pushed a commit to nodejs/node that referenced this pull request Aug 22, 2021
Expose toUSVString to it can be used by user libraries.

PR-URL: #39814
Refs: nodejs/undici#986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
lpinca pushed a commit to nodejs/node that referenced this pull request Aug 22, 2021
Expose toUSVString so it can be used by user libraries.

PR-URL: #39814
Refs: nodejs/undici#986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Aug 22, 2021
Expose toUSVString so it can be used by user libraries.

PR-URL: #39814
Refs: nodejs/undici#986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit to nodejs/node that referenced this pull request Sep 4, 2021
Expose toUSVString so it can be used by user libraries.

PR-URL: #39814
Refs: nodejs/undici#986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ronag ronag deleted the usvstring branch October 28, 2021 08:10
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix(fetch): toUSVString

* fixup

* fixup

* fixup
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix(fetch): toUSVString

* fixup

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants