Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AP-4525] Add infoFiled icon; improve storybook icon previews visibility #723

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[AP-4525] Add infoFiled icon; improve storybook icon previews visibility #723

merged 3 commits into from
Jun 24, 2024

Conversation

jedrasik
Copy link
Contributor

What

  • What was done in this Pull Request
    • add infoFilled icon
    • adjust default icon colors to be more visible

Testing

  • Is this change covered by the unit tests?

  • Is this change covered by the integration tests?

  • Is this change covered by the automated acceptance tests? (if applicable)

Compatibility

  • Does this change maintain backward compatibility?

Screenshots

Before

After

@jedrasik jedrasik requested a review from a team as a code owner June 21, 2024 20:12
@aws-amplify-eu-west-1 AWS Amplify (eu-west-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-723.du3gff836giqw.amplifyapp.com

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jedrasik jedrasik merged commit dd3fbd8 into master Jun 24, 2024
6 of 7 checks passed
@jedrasik jedrasik deleted the ap-4525-add-infoFilled-icon branch June 24, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msoltysik msoltysik msoltysik approved these changes

@raczyk raczyk raczyk approved these changes

@dominpn dominpn dominpn approved these changes

@janosio janosio Awaiting requested review from janosio janosio is a code owner automatically assigned from nordcloud/core-frontend-reviewers

@JevgenijSolomin JevgenijSolomin Awaiting requested review from JevgenijSolomin JevgenijSolomin is a code owner automatically assigned from nordcloud/core-frontend-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jedrasik @msoltysik @raczyk @dominpn