Skip to content

Commit

Permalink
Add type-ignore comments to functional tests
Browse files Browse the repository at this point in the history
Specifically, various tests which assign attributes to functions need
attr-defined ignore rules.
  • Loading branch information
sirosen committed May 31, 2024
1 parent 51da5c1 commit 7a1f154
Show file tree
Hide file tree
Showing 7 changed files with 49 additions and 49 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ def test(p):
assert THINGS, "setup didn't run I think"


test.paramList = (1,)
test.paramList = (1,) # type: ignore[attr-defined]
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ def check(a):
def test_params(self, a):
pass

test_params.paramList = (1, 2)
test_params.paramList = (1, 2) # type: ignore[attr-defined]
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ def test_params(self, a):
assert self.test_setup
assert self.setup

test_params.paramList = (1, 2)
test_params.paramList = (1, 2) # type: ignore[attr-defined]
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ def check(a):
def test_params(self, a):
pass

test_params.paramList = (1, 2)
test_params.paramList = (1, 2) # type: ignore[attr-defined]
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ def test_params(self, a):
assert self.test_setup
assert self.setup

test_params.paramList = (1, 2)
test_params.paramList = (1, 2) # type: ignore[attr-defined]
Original file line number Diff line number Diff line change
Expand Up @@ -7,65 +7,65 @@ class SomeTests(unittest.TestCase):
def test_ok(self):
pass

test_ok.tags = ["method", "pass"]
test_ok.a = 0
test_ok.b = 1
test_ok.tags = ["method", "pass"] # type: ignore[attr-defined]
test_ok.a = 0 # type: ignore[attr-defined]
test_ok.b = 1 # type: ignore[attr-defined]

def test_typeerr(self):
raise TypeError("oops")

test_typeerr.tags = ["method"]
test_typeerr.tags = ["method"] # type: ignore[attr-defined]

def test_failed(self):
print("Hello stdout")
assert False, "I failed"

test_failed.tags = ["method"]
test_failed.tags = ["method"] # type: ignore[attr-defined]

def test_skippy(self):
raise unittest.SkipTest("I wanted to skip")

test_skippy.a = 1
test_skippy.b = 1
test_skippy.a = 1 # type: ignore[attr-defined]
test_skippy.b = 1 # type: ignore[attr-defined]

def test_gen_method(self):
def check(x):
assert x == 1

check.b = 2
check.b = 2 # type: ignore[attr-defined]
yield check, 1
yield check, 2

test_gen_method.a = 1
test_gen_method.b = 1
test_gen_method.a = 1 # type: ignore[attr-defined]
test_gen_method.b = 1 # type: ignore[attr-defined]

def test_params_method(self, a):
self.assertEqual(a, 1)

test_params_method.paramList = (1, 2)
test_params_method.a = 1
test_params_method.paramList = (1, 2) # type: ignore[attr-defined]
test_params_method.a = 1 # type: ignore[attr-defined]


def test_func():
assert 1 == 1


test_func.a = 1
test_func.b = 0
test_func.tags = ["func", "pass"]
test_func.a = 1 # type: ignore[attr-defined]
test_func.b = 0 # type: ignore[attr-defined]
test_func.tags = ["func", "pass"] # type: ignore[attr-defined]


def test_gen():
def check(a, b):
assert a == b

check.tags = ["func"]
check.tags = ["func"] # type: ignore[attr-defined]
for i in range(0, 5):
yield check, (i, i)


test_gen.testGenerator = True
test_gen.tags = ["func"]
test_gen.testGenerator = True # type: ignore[attr-defined]
test_gen.tags = ["func"] # type: ignore[attr-defined]


def test_gen_nose_style():
Expand All @@ -88,19 +88,19 @@ def test_fixt():
assert did_setup


test_fixt.setup = setup
test_fixt.setup = setup # type: ignore[attr-defined]


def test_params_func(a):
assert a == 1


test_params_func.paramList = (1, 2)
test_params_func.tags = ["func"]
test_params_func.paramList = (1, 2) # type: ignore[attr-defined]
test_params_func.tags = ["func"] # type: ignore[attr-defined]


def test_params_func_multi_arg(a, b):
assert a == b


test_params_func_multi_arg.paramList = ((1, 1), (1, 2), (2, 2))
test_params_func_multi_arg.paramList = ((1, 1), (1, 2), (2, 2)) # type: ignore[attr-defined] # noqa: E501
Original file line number Diff line number Diff line change
Expand Up @@ -7,65 +7,65 @@ class SomeTests(unittest.TestCase):
def test_ok(self):
pass

test_ok.tags = ["method", "pass"]
test_ok.a = 0
test_ok.b = 1
test_ok.tags = ["method", "pass"] # type: ignore[attr-defined]
test_ok.a = 0 # type: ignore[attr-defined]
test_ok.b = 1 # type: ignore[attr-defined]

def test_typeerr(self):
raise TypeError("oops")

test_typeerr.tags = ["method"]
test_typeerr.tags = ["method"] # type: ignore[attr-defined]

def test_failed(self):
print("Hello stdout")
assert False, "I failed"

test_failed.tags = ["method"]
test_failed.tags = ["method"] # type: ignore[attr-defined]

def test_skippy(self):
raise unittest.SkipTest("I wanted to skip")

test_skippy.a = 1
test_skippy.b = 1
test_skippy.a = 1 # type: ignore[attr-defined]
test_skippy.b = 1 # type: ignore[attr-defined]

def test_gen_method(self):
def check(x):
assert x == 1

check.b = 2
check.b = 2 # type: ignore[attr-defined]
yield check, 1
yield check, 2

test_gen_method.a = 1
test_gen_method.b = 1
test_gen_method.a = 1 # type: ignore[attr-defined]
test_gen_method.b = 1 # type: ignore[attr-defined]

def test_params_method(self, a):
self.assertEqual(a, 1)

test_params_method.paramList = (1, 2)
test_params_method.a = 1
test_params_method.paramList = (1, 2) # type: ignore[attr-defined]
test_params_method.a = 1 # type: ignore[attr-defined]


def test_func():
assert 1 == 1


test_func.a = 1
test_func.b = 0
test_func.tags = ["func", "pass"]
test_func.a = 1 # type: ignore[attr-defined]
test_func.b = 0 # type: ignore[attr-defined]
test_func.tags = ["func", "pass"] # type: ignore[attr-defined]


def test_gen():
def check(a, b):
assert a == b

check.tags = ["func"]
check.tags = ["func"] # type: ignore[attr-defined]
for i in range(0, 5):
yield check, (i, i)


test_gen.testGenerator = True
test_gen.tags = ["func"]
test_gen.testGenerator = True # type: ignore[attr-defined]
test_gen.tags = ["func"] # type: ignore[attr-defined]


def test_gen_nose_style():
Expand All @@ -88,19 +88,19 @@ def test_fixt():
assert did_setup


test_fixt.setup = setup
test_fixt.setup = setup # type: ignore[attr-defined]


def test_params_func(a):
assert a == 1


test_params_func.paramList = (1, 2)
test_params_func.tags = ["func"]
test_params_func.paramList = (1, 2) # type: ignore[attr-defined]
test_params_func.tags = ["func"] # type: ignore[attr-defined]


def test_params_func_multi_arg(a, b):
assert a == b


test_params_func_multi_arg.paramList = ((1, 1), (1, 2), (2, 2))
test_params_func_multi_arg.paramList = ((1, 1), (1, 2), (2, 2)) # type: ignore[attr-defined] # noqa: E501

0 comments on commit 7a1f154

Please sign in to comment.