Update mongoos 56 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good and works for me, 2 commits are fully reasonably 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I have picked up work again on the Debian package for ympd, and noticed that mongoose received a few updates. I haven't squashed my commits yet, I'd like you to review those before I do that. (I can remove the mongoose 5.6 update commit so you can do it yourself if you prefer, only using second commit wrt my edits to mpd_client.c)
(The reason I have done this is I also started working on packaging mongoose on Debian as a shared library, and I picked the latest release as a basis)
One change is that mg_iterate_over_connections was removed, and so a loop with mg_next is to be used now.
Thank you !