Bring back complete favicon feature set #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Sep 21, 2024
| @@ -37,7 +37,8 @@ | |||
| "template": | |||
| [ | |||
| "default", | |||
| "modern" | |||
| "modern", | |||
| "template" | |||
There was a problem hiding this comment.
Maybe call this npgsql_template to make it clearer it's our customizations etc.
| @@ -0,0 +1,46 @@ | |||
| {{!Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license.}} | |||
|
|
|||
| <head> | |||
There was a problem hiding this comment.
Just noting that this override means we need to react if there are any upstream changes in the modern template... This is what caused things when I was upgrading things, which is why I removed it.
I'm hoping maybe there's some way to just add our favicons rather than replacing the entire <head>, which seems like it could cause similar trouble in the future... Is something like that possible, like some more targeted partial or extensibility hook specifically for favicon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent docfx update we lost some advanced favicon features.
This brings them back and also updates them with regards to additional featuress.