Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packageRelativePath): fix 'where' for file deps #142

Closed
wants to merge 2 commits into from

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Jan 18, 2019

Reopening #95, #137

Fix 'where' for file deps. It makes more sense for the 'where' to be the
directory the file is in (and was possibly built in) than it being the
file itself, having no use whatsoever.

See https://npm.community/t/3364

@larsgw larsgw requested a review from a team as a code owner January 18, 2019 21:13
@aeschright aeschright added semver:minor new backwards-compatible feature semver:major backwards-incompatible breaking changes needs-discussion labels Jan 22, 2019
@zkat zkat force-pushed the release-next branch 3 times, most recently from db63b89 to b09bc8c Compare January 23, 2019 18:36
@zkat zkat force-pushed the release-next branch 2 times, most recently from 06cdf5b to f957798 Compare February 20, 2019 20:42
Fix 'where' for file deps. It makes more sense for the 'where' to be the 
directory the file is in (and was possibly built in) than it being the 
file itself, having no use whatsoever.

See https://npm.community/t/3364
@isaacs isaacs force-pushed the release-next branch 2 times, most recently from 896149d to 31718e7 Compare June 29, 2019 21:55
@mikemimik mikemimik added Release 6.x work is associated with a specific npm 6 release Bug thing that needs fixing and removed semver:major backwards-incompatible breaking changes labels Nov 26, 2019
@mikemimik mikemimik added this to the Release 6.14.0 milestone Nov 26, 2019
@mikemimik mikemimik added semver:patch semver patch level for changes and removed semver:minor new backwards-compatible feature labels Dec 3, 2019
@mikemimik mikemimik closed this in 8676429 Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants