Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: explain - mark when dependency is bundled #2750

Closed
wants to merge 3 commits into from

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Feb 22, 2021

when using npm explain <package> its useful to see if the package has been bundled. this is especially useful when trying to understand the provenance of a package's content

image

it would additionally be helpful to indicate when an edge includes a dependency as bundled, but that will require a change in @npmcli/arborist's Edge.prototype.explain

@kumavis
Copy link
Contributor Author

kumavis commented Feb 22, 2021

if npm/arborist#241 is acceptable, I will update this PR to include a bundled decoration for edges as well. very helpful for seeing where in the branch of a dep tree the bundle happened

@kumavis
Copy link
Contributor Author

kumavis commented Feb 22, 2021

here's the improvement with bundled flag on Edges
image

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 22, 2021
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@wraithgar wraithgar added semver:minor new backwards-compatible feature and removed semver:patch semver patch level for changes labels Feb 25, 2021
When using `npm explain <package>` it's useful to see if the package has
been bundled. This is especially useful when trying to understand the
provenance of a package's content

PR-URL: npm#2750
Credit: @kumavis
Close: npm#2750
Reviewed-by: @nlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants