Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove node_modules post-validation #4913

Merged
merged 1 commit into from
May 18, 2022
Merged

fix(ci): remove node_modules post-validation #4913

merged 1 commit into from
May 18, 2022

Conversation

wraithgar
Copy link
Member

The removal of node_modules was happening in a race with the loading of
the virtualTree, and before the validation of the package-lock against
the package.json. This defers the removal till after all that
validation has happened.

It also makes the errors thrown usage errors, and refactors the tests to
be real.

@wraithgar wraithgar requested a review from a team as a code owner May 18, 2022 18:19
The removal of node_modules was happening in a race with the loading of
the virtualTree, and before the validation of the package-lock against
the package.json.  This defers the removal till after all that
validation has happened.

It also makes the errors thrown usage errors, and refactors the tests to
be real.
@fritzy fritzy merged commit 400c80f into latest May 18, 2022
@fritzy fritzy deleted the gar/ci-tests branch May 18, 2022 22:34
@fritzy fritzy mentioned this pull request May 18, 2022
@lukekarrys lukekarrys mentioned this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants