Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.13.1 #494

Merged
merged 23 commits into from
Nov 18, 2019
Merged

Release 6.13.1 #494

merged 23 commits into from
Nov 18, 2019

Conversation

claudiahdz
Copy link
Contributor

@claudiahdz claudiahdz commented Nov 18, 2019

6.13.1 (2019-11-18)

BUG FIXES

TESTING

DOCUMENTATION

DEPENDENCIES

ruyadorno and others added 20 commits November 13, 2019 20:15
In the approved RFC it was documented that `npm fund` should also
support a shorthand version of the `funding` property using only a
string instead of an object.

This commit fixes it and adds tests to ensure its behavior.

PR-URL: #472
Credit: @ruyadorno
Close: #472
Reviewed-by: @claudiahdz
- Add `tap-snapshot` folder to `.npmignore`
- Fixes #461

PR-URL: #471
Credit: @ruyadorno
Close: #471
Reviewed-by: @claudiahdz
This commit would make it possible to run `npm` installed on Windows within Windows Subsystem for Linux.

It is required, however, that the end of line characters of `npm` and `npx` be `\n` for the fix to take effect.

PR-URL: #253
Credit: @infinnie
Close: #253
Reviewed-by: @claudiahdz
chore(docs): fix styling issues on man and html docs

chore(docs): fix absolute links on cli docs
2427 bytes -> 2045 bytes

PR-URL: #463
Credit: @XhmikosR
Close: #463
Reviewed-by: @claudiahdz
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
chore(docs): change chmod markdown files

chore(docs): update gitignore
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
PR-URL: #485
Credit: @claudiahdz
Close: #485
Reviewed-by: @claudiahdz
This was broken when the support/funding functionality changed the
return value to no longer track the promise for the quick audit
printing.

It was not caught by tests, because they were only running against the
--json output, and not verifying the quick audit results in any way.

Added a test to track the --json quick audit results (which were not
broken, but someday could become so) and the human printed quick audit
results (which were broken).

Paired with @ruyadorno @mikemimik

PR-URL: #486
Credit: @isaacs
Close: #486
Reviewed-by: @claudiahdz
PR-URL: #493
Credit: @claudiahdz
Close: #493
Reviewed-by: @claudiahdz
@claudiahdz claudiahdz requested a review from a team as a code owner November 18, 2019 17:11
@ljharb
Copy link
Contributor

ljharb commented Nov 18, 2019

Link to the changelog?

Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm-deploy-user
Copy link

npm-deploy-user commented Nov 18, 2019

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 38.4s 36.9s 39.6s 45s🛑 32.4s 35.2s🛑 24.9s 27.8s🛑 31.4s 35.2s🛑
repeat install 9s 9.6s🛑 8s 8.8s🛑 7.7s 8.4s🛑 6.9s 7.4s🛑 8.4s 9.3s🛑
with warm cache 28.9s 31.9s🛑 32.6s 34.9s🛑 27.3s 30.2s🛑 21.4s 25.5s🛑 29.4s 29.5s🛑
with node_modules 8.7s 9.4s🛑 7.3s 9.7s🛑 8.3s 8.1s 7.4s 7.4s🛑 8.3s 8.8s🛑
with lockfile 31.8s 32.6s🛑 27.8s 30.7s🛑 26.5s 28s🛑 18.4s 21.1s🛑 24.4s 25.6s🛑
with warm cache and node_modules 9s 8.8s 8.3s 8.5s🛑 7.7s 8.1s🛑 8.9s 7.3s 10.3s 9s
with warm cache and lockfile 25.2s 23.9s 24.9s 27.9s🛑 24s 24s🛑 15.2s 16s🛑 20.2s 21.5s🛑
with node_modules and lockfile 9.3s 9.5s🛑 8.6s 9.8s🛑 8.3s 9s🛑 7.5s 7.6s🛑 8.8s 9.3s🛑

@claudiahdz claudiahdz merged commit b829d62 into latest Nov 18, 2019
@isaacs isaacs deleted the release-6.13.1 branch August 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.