Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes nodejs tests #696

Closed
wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Contributor

  • Fixes ability to run tests using an arbitrary node bin
    • Most tests were failing due to mismatching versions of node (local compiled version vs system version)
  • Fixes make test-npm in nodejs repo
    • Added tap-snapshots folder (fixes snapshot-dependent tests)
    • Added required .npmrc root file (fixes broken config tests)
  • Added v14 to supported matrix

Fixes npm/statusboard#45

- Fixes ability to run tests using an arbitrary node bin
- Fixes `make test-npm` in nodejs repo
  - Added `tap-snapshots` folder
  - Added required `.npmrc` root file

Fixes npm/statusboard#45
@ruyadorno ruyadorno added semver:patch semver patch level for changes Release 6.x work is associated with a specific npm 6 release Bug thing that needs fixing labels Jan 16, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 2 milestone Jan 16, 2020
@ruyadorno ruyadorno requested a review from a team January 16, 2020 16:04
@@ -7,7 +7,8 @@ var supportedNode = [
{ver: '10', min: '10.0.0'},
{ver: '11', min: '11.0.0'},
{ver: '12', min: '12.0.0'},
{ver: '13', min: '13.0.0'}
{ver: '13', min: '13.0.0'},
{ver: '14', min: '14.0.0'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this in advance :-)

could perhaps this logic be changed to use semver so that every new node version is always treated as supported unless explicitly marked as not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's in our radar to change that for v7 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’d also be nice tho for the last 6.x build to not report that new nodes are unsupported forever :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, that's a good point! I agree 👍 that could be a good community contribution wink wink

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #697 (i'll need some help)

Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix make test-npm in node
3 participants