BREAKING CHANGE: Invalidate special chars #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Feb 13, 2017
index.js
Outdated
| @@ -68,6 +68,10 @@ var validate = module.exports = function(name) { | |||
| warnings.push("name can no longer contain capital letters") | |||
| } | |||
|
|
|||
| if (/[~'!()*]/.test(name.split('/').slice(-1)[0])) { | |||
| warnings.push('name can no longer contain special characters ("~\'!()*")') | |||
There was a problem hiding this comment.
curious about the choice of using warn rather than error, I imagine:
- on the registry we'll block new publications that cause this warning.
- the CLI will log the message but allow the publish.
- old packages will continue to be able to be published?
This seems reasonable to me, just refreshing myself with this module.
|
This seems to do what it says on the tin. Since it only affects new packages, I'm fine with this. Agreed that it is a breaking change. |
|
Changes Unknown when pulling 55f1162 on invalidate-special-chars into ** on master**. |
|
Merging and publishing as v3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer allow
~!'()*in package names in any position (Surprise, they're url-safe!)The first commit contains the relevant change; the second commit upgrades the
builtins&tapdeps; the final commit (noisily)standard-formats the repo.