Skip to content

Commit

Permalink
Fix missing size when doing ec dump
Browse files Browse the repository at this point in the history
Signed-off-by: Nathaniel Mitchell <nathaniel.p.mitchell@intel.com>
  • Loading branch information
npmitche committed Jul 30, 2024
1 parent 81052e8 commit 7699560
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions chipsec/utilcmd/ec_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,23 @@ def parse_arguments(self) -> None:
parser_offset = ArgumentParser(add_help=False)
parser_offset.add_argument('offset', type=lambda x: int(x, 0), nargs='?', default=0, help="offset")

parser_sz = ArgumentParser(add_help=False)
parser_sz.add_argument("size", type=lambda sz: int(sz, 0), nargs='?', help="size")
parser_dmpsz = ArgumentParser(add_help=False)
parser_dmpsz.add_argument("size", type=lambda sz: int(sz, 0), nargs='?', default=0x160, help="size")

parser_rdsz = ArgumentParser(add_help=False)
parser_rdsz.add_argument("size", type=lambda sz: int(sz, 0), nargs='?', default=None, help="size")

subparsers = parser.add_subparsers()

parser_command = subparsers.add_parser('command')
parser_command.add_argument("cmd", type=lambda sz: int(sz, 0), help="EC command to issue")
parser_command.set_defaults(func=self.command)

parser_dump = subparsers.add_parser('dump', parents=[parser_sz])
parser_dump.set_defaults(func=self.dump, size=0x160)
parser_dump = subparsers.add_parser('dump', parents=[parser_dmpsz])
parser_dump.set_defaults(func=self.dump)

parser_read = subparsers.add_parser('read', parents=[parser_offset, parser_sz])
parser_read.set_defaults(func=self.read, size=None)
parser_read = subparsers.add_parser('read', parents=[parser_offset, parser_rdsz])
parser_read.set_defaults(func=self.read)

parser_write = subparsers.add_parser('write', parents=[parser_offset])
parser_write.add_argument("wval", type=lambda sz: int(sz, 0), help="byte value to write into EC memory")
Expand Down

0 comments on commit 7699560

Please sign in to comment.