Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ribbon menu match the visual style #111

Closed
VitalSkib opened this issue Mar 7, 2023 · 9 comments
Closed

Make the ribbon menu match the visual style #111

VitalSkib opened this issue Mar 7, 2023 · 9 comments

Comments

@VitalSkib
Copy link

Hey.
I wonder if you have plans to also make the msstyleEditor interface dark (as an option)?
My eyes are not so good lately.. 🫣
tia

@nptr
Copy link
Owner

nptr commented Mar 9, 2023

msstyleEditor is supposed to be rendered according to whatever the active visual style says. It doesn't work properly however because the (3rd party) ribbon control ignores visual styles and i didn't get around to fix it yet.

@VitalSkib
Copy link
Author

Oh..
Yep, I have a dark (Night) custom theme in Windows and it looks like this for me (image below).
Maybe you can make this ribbon collapsible at least, as in most applications with a ribbon?

msstyleEditor

@nptr
Copy link
Owner

nptr commented Mar 10, 2023

No collapsible ribbon, but i have a test build ready for you that should make the ribbon and dock panels work better with non-light visual styles: msstyleEditor_test.zip

Let me know how it works for you, and if, which UI elements need improvement.

@nptr nptr changed the title Make msstyleEditor UI Dark? Make the ribbon menu match the visual style Mar 10, 2023
@VitalSkib
Copy link
Author

No collapsible ribbon, but i have a test build ready for you that should make the ribbon and dock panels work better with non-light visual styles: msstyleEditor_test.zip

Let me know how it works for you, and if, which UI elements need improvement.

Oh, it's so cool, now it's completely dark! 😎👍
Thanks a lot!
As for "which UI elements need improvement", I would change the icons to more modern ones and maybe a custom color choice for the background of the Image View panel,, but this is not a problem at all..
Thanks again!

msstyleEditor

@VitalSkib
Copy link
Author

Oh, by the way, any way to save the settings on exit?
For example, I set the black background color for the Image View panel, and I would like to see this background color at the next launch.
Instead of changing it every time..
Is it possible?

@nptr
Copy link
Owner

nptr commented Mar 10, 2023

Good to hear, thank for testing. I hope to get the changes in the next release. I am not fully pleased yet with the ribbon tabs. Its hard to see the active one. Would you mind posting a screenshot of the "Show controls" dialog, so I can see how a regular tab control would look like with your visual style?

About persisting the settings: Maybe in the future. There are not a lot of options so I chose to delay that task until there is a stronger need. With new features it often is a time and motivation thing.

@VitalSkib
Copy link
Author

Would you mind posting a screenshot of the "Show controls" dialog..

Yes, I attached it..

About persisting the settings: Maybe in the future.

Sure, take your time, no problems with this..

Control Preview

@nptr
Copy link
Owner

nptr commented Mar 10, 2023

Version 2.0.0.5 contains the fix to this issue.
Its similar to your test version, but with improved ribbon tab borders. The dockpanel background handling is also
a bit different. That was necessary to get a reasonable look on non-black & non-white visual styles.

I hope this still look well on your system.

@VitalSkib
Copy link
Author

Yes, it looks a little better.
Thank you very much for the response.

@nptr nptr closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants