Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing font from resource string #114

Closed
3 tasks done
migozz opened this issue Mar 30, 2023 · 4 comments
Closed
3 tasks done

Changing font from resource string #114

migozz opened this issue Mar 30, 2023 · 4 comments
Labels

Comments

@migozz
Copy link

migozz commented Mar 30, 2023

Windows Version: Win7

Expected behavior
In version 1.4.0.6, when you select a Font from String table Resources (for example, in TaskBar::Toolbar → Font), there are strings like "501 - Tahoma, 8", and you can select Any string.
In version 2.0.0.5, there's string "501", but without font name in the combobox, and when you open a drop-down list, there are only 7 strings (without numbers), despite the actual number of lines. And when you select a font, instead of a resource number (501) there's displayed a Font Name. And not all "fonts" are available to select.
So it is needed to use older version to change font.

Checklist

  • My uxtheme.dll is patched
  • I am using the latest version of msstyleEditor
  • None of the other issues cover this
@migozz migozz added the bug label Mar 30, 2023
@nptr
Copy link
Owner

nptr commented Apr 1, 2023

I distinguish two major cases

  • String table missing. msstyleEditor warns here and only displays the resource IDs.
  • String table found. msstyleEditor displays the value behind the ID.
String table missing String table found
image image

A third case could be a reference to a non-existing resource. Either ID or string table entry must be wrong in that case. I think i fall back to the resource ID just for this element then. Not sure.

Would any of this explain your observation?

@migozz
Copy link
Author

migozz commented Apr 2, 2023

My theme: https://drive.google.com/file/d/1qLbQ7ZYBG0ANA9253PF4oKbSg4d3tsA2/view?usp=sharing

Resources:
reshacker

v.1.4.0.6
msstyleeditor1406

msstyleeditor2005

So, 501 and 502, 506, 509(?) are not visible, but 503 is visible. But I don't know that it's actually 503 (until I open in old editor).

@nptr
Copy link
Owner

nptr commented Apr 2, 2023

Yep, something is off. Thanks for sharing the style, that makes troubleshooting easier. l am out of town this week, so a bit more patience is necessary until I can tackle the problem.

@nptr
Copy link
Owner

nptr commented Apr 9, 2023

I found and fixed the bug. The font resource detection was flawed. Fonts without style or quality specifier were not detected as fonts. So "Tahoma, 8" was not considered a font and was subsequently not available in the font selection box.

Use version 2.0.0.6 to have it working again.

@nptr nptr closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants