Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical hotkeys to manipulate Image View don't work when Image View has focus #123

Closed
3 tasks done
TiberiumFusion opened this issue May 3, 2023 · 2 comments
Closed
3 tasks done
Labels

Comments

@TiberiumFusion
Copy link

TiberiumFusion commented May 3, 2023

Windows Version: 6.1.7601.26465

Expected behavior
Pressing number keys 1, 2, 3, etc should switch the IMAGEFILE displayed in the Image View when the Image View is focused.

Actual behavior
Pressing number keys 1, 2, 3, etc only switches the IMAGEFILE displayed in the Image View when an entirely different control has focus - the Class View.

Additional context

  1. Open any msstyles file.
  2. Use the Class View to navigate to an element that has a graphic. For example, TrayNotifyHorizOpen::Button->Common Properties.
  3. Ensure that the Class View still has the focus.
  4. Press keys 1, 2, 3, etc.
    Observe that the Image View correctly switches to a display a different IMAGEFILE for the corresponding pressed number key.
  5. Click anywhere inside the Image View. The Image View now has the focus.
    A practical example of this is simply right clicking the Image View in order to change its background.
  6. Press keys 1, 2, 3, etc.
    Observe that the Image View does not respond. It does not switch to display a different IMAGEFILE for the corresponding pressed number key.

Checklist

  • My uxtheme.dll is patched
  • I am using the latest version of msstyleEditor (2.0.0.7)
  • None of the other issues cover this (afaik, this is not an unambiguous thing to search)
@TiberiumFusion TiberiumFusion changed the title Numerical hotkeys to manipulate Image View only work when Class View has focus Numerical hotkeys to manipulate Image View don't work when Image View has focus May 3, 2023
@nptr
Copy link
Owner

nptr commented May 4, 2023

Thanks for the report, I see the problem. I even wrote a comment in code saying "very hacky". Never got to doing it properly. Next version will have it fixed.

@nptr
Copy link
Owner

nptr commented May 9, 2023

I now implemented the hotkeys application-global, so they work regardless of the active control. For that I had to change the hotkeys to Ctrl + <Num> however. Single key strokes are consumed by certain controls already and would not conform to Windows UX guidelines anyways. I suggest to use the control key on the right half of the keyboard with the regular number keys for best ergonomics.

Please see draft version 2.0.0.8.

@nptr nptr closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants