Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect density for RW-1 water substitute in density corrections file #347

Closed
ojalaj opened this issue Sep 20, 2017 · 4 comments
Closed
Assignees

Comments

@ojalaj
Copy link

ojalaj commented Sep 20, 2017

In HEN_HOUSE/pegs4/density_corrections/compounds/rw-1watersubstitute_polyethenebased.density the density of the material is 9.6999998. Should it be 0.96999998?

@ftessier
Copy link
Member

Most probably, of course!! Can anybody provide a reference on this particular material? It would be nice to confirm the numerical value as well.

@ftessier
Copy link
Member

We have to check the actual density correction values of course, not just the density value in the header.

@ojalaj
Copy link
Author

ojalaj commented Sep 21, 2017

I went through the density correction files trying to find one suitable for RMI SW and came across this one. Unfortunately I don't have further experience using it or information about it, but after some Google search, in http://iopscience.iop.org/0031-9155/60/24/9403 and in the reference therein there is some supporting information.

@ftessier ftessier self-assigned this Oct 7, 2017
@ftessier
Copy link
Member

ftessier commented Nov 8, 2017

The density effect correction values in the rw-1watersubstitute_polyethenebased.density themselves do correspond to the (wrong) density of 9.6999998 instead of 0.96999998. I am preparing a new file with the correct data.

ftessier added a commit that referenced this issue Nov 8, 2017
Regenerate the density effect correction file for the RW-1 water
substitute material, for the correct density ~0.97, instead of the
previously erroneous value of ~9.7. The updated data was obtained from
the estar program, using the correct density, but otherwise unchanged
I-value and chemical composition values, as shown in the file header.
ftessier added a commit that referenced this issue Nov 15, 2017
Regenerate the density effect correction file for the RW-1 water
substitute material, for the correct density ~0.97, instead of the
previously erroneous value of ~9.7. The updated data was obtained from
the estar program, using the correct density, but otherwise unchanged
I-value and chemical composition values, as shown in the file header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants