Fix file includes in egs++ input files #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix file includes in egs++, so that the file content is inserted into the total input file content before everything else is processed. This fixes a bug where composite geometries that referenced a geometry in the external file would crash, because the external geometry hadn't been loaded and assigned a name yet.
rtownson
force-pushed
the
fix-file-includes
branch
from
1cb635c
to
b7190ea
Compare
mainegra
approved these changes
Mar 25, 2020
ftessier
approved these changes
Jun 2, 2020
blakewalters
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes file includes in egs++, so that the external file content is inserted into the total input file content before everything else is processed. This fixes a bug where composite geometries that referenced a geometry in the external file would crash, because the external geometry hadn't been loaded and assigned a name yet.