feat: downloadStill from media pool #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 84.69% 83.61% -1.08%
==========================================
Files 189 191 +2
Lines 5951 6055 +104
Branches 887 956 +69
==========================================
+ Hits 5040 5063 +23
- Misses 911 960 +49
- Partials 0 32 +32 ☔ View full report in Codecov by Sentry. |
Julusian
commented
Aug 16, 2024
| * @param format The pixel format to return for the downloaded image. 'raw' passes through unchanged, and will be RLE encoded. | ||
| * @returns Promise which returns the image once downloaded. If the still slot is not in use, this will throw | ||
| */ | ||
| public async downloadStill(index: number, format: 'raw' | 'rgba' | 'yuv' = 'rgba'): Promise<Buffer> { |
There was a problem hiding this comment.
I guess that format should probably be replaced with an options object, for future expansion
nytamin
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of myself/Bitfocus Companion
Type of Contribution
This is a Feature
New Behavior
This adds the ability to download still frames from the media pool.
To support this, rle decoding and yuva422 to rgba colour conversion has been implemented too.
Testing Instructions
Other Information
Status