Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: FEC Explorer Table query issued twice #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nxanil
Copy link
Collaborator

@nxanil nxanil commented Jan 12, 2021

@killanch @chaitanyahalbe

Fixed Issue nuagenetworks/vis-graphs#429. Please have a look.

@chaitanyahalbe
Copy link
Contributor

@nxanil Will test this on a setup and get back to you.

@chaitanyahalbe
Copy link
Contributor

@nxanil Verified this. It works. Please ignore the 400 errors in the below screenshots as the ES did not have the nuage_fec index. The UI shows up with 'Unable to fetch data' message in the table in this case.

Before:
image

After:
image

cc @killanch

@killanch
Copy link
Contributor

@chaitanyahalbe can you build a war file with these changes and provide to @sreddy80?
@sreddy80 could you pls do sanity tests with the above war file? UI visualizations should work as expected

@chaitanyahalbe
Copy link
Contributor

@chaitanyahalbe can you build a war file with these changes and provide to @sreddy80?
@sreddy80 could you pls do sanity tests with the above war file? UI visualizations should work as expected

@killanch Gave the war file to @sreddy80 for testing.

@nxanil
Copy link
Collaborator Author

nxanil commented Apr 13, 2021

@chaitanyahalbe
This PR is already approved. Can we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants