Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira: NSDWAN-1 : Removing vspk version number from packages. #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkarnam
Copy link

@mkarnam mkarnam commented Mar 23, 2020

Description:-

  • Whenever we upgrade vspk in SDWAN portal, we have to replace all the instances of version numbers in our code base. If API version number is not present in package names, it is easy for us to switch between vspk versions. Version number is anyway maintained in pom.xml to differentiate between versions. Don't see much of a use for maintaining version number at package level. If there is no harm in removing version number from package names, please approve this pull Request.

Changes: -

  • Updated APIVersionWriter to remove version number from packages.

Testing:

  • Generated VSPK java and checked there is no version number in vspk java

Changes: -

- Update APIVersionWriter to remove version number from packages.

Testing:

- Generated VSPK java and checked there is no version number in vspk.
@pdumais pdumais self-assigned this Mar 23, 2020
@pdumais
Copy link
Collaborator

pdumais commented Mar 23, 2020

Can you confirm the resulting code by posting an example usage?

Also, this would need to be postponed to the next major release since this will create a backward incompatibility.

@pdellaert can comment some more.

@pdellaert
Copy link
Member

@pdumais, @mkarnam , isn't this going to break any integration in the world? Everybody using the Java VSPK will have to change their imports?

So yes, this will have to be delayed until the next major release.

@pdellaert pdellaert added enhancement Broken BC Breaks backwards compatibility labels Mar 24, 2020
@pdumais
Copy link
Collaborator

pdumais commented Mar 24, 2020

Yes it will. Waiting for the next major release is preferable since we will have to change the import anyway then (since the version number is part of the imported name)

@pdellaert
Copy link
Member

Sure, will track this for then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Broken BC Breaks backwards compatibility enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants