[Processor] Block worker allocation if worker allocator is terminated #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
requested changes
Dec 14, 2023
TomerShor
requested changes
Dec 17, 2023
TomerShor
reviewed
Dec 18, 2023
liranbg
requested changes
Dec 18, 2023
Comment on lines
+1707
to
+1723
| createFunctionOptions.FunctionConfig.Spec.Build.FunctionSourceCode = base64.StdEncoding.EncodeToString([]byte(` | ||
| terminated = False | ||
| def handler(context, event): | ||
| if terminated: | ||
| context.logger.info("Got event after termination") | ||
| else: | ||
| context.logger.info("Got http event") | ||
| return "got http event!" | ||
|
|
||
| def callback(): | ||
| import time | ||
| time.sleep(3) | ||
| terminated = True | ||
|
|
||
| def init_context(context): | ||
| context.platform.set_termination_callback(callback) | ||
| `)) |
There was a problem hiding this comment.
suggestion -
why not using go embed? would let you write python in x.py and have it linted and etc
There was a problem hiding this comment.
@liranbg That's a good idea. I can implement it in another PR and transfer all our raw-code function definitions in tests to embed, just to maintain a holistic approach. What do you think?
|
@liranbg after termination flow, pod fully terminates. Termination flow is invoked on pod termination by termination signals. |
liranbg
approved these changes
Dec 19, 2023
TomerShor
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.iguazeng.com/browse/NUC-110