Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deployment] Introduce init containers #3097

Merged
merged 12 commits into from
Dec 21, 2023
Merged

[Deployment] Introduce init containers #3097

merged 12 commits into from
Dec 21, 2023

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Dec 19, 2023 •
edited

Jira - https://jira.iguazeng.com/browse/NUC-83

  • Implement init containers implementation for Nuclio function.
    User can specify initContainers in function spec which is the value of type []*v1.Container (same as in k8s yaml). If something goes wrong with init containers, we will inform about this in UI. For instance:

Screenshot 2023-12-19 at 15 50 58

  • Some sidecar-related logic was transformed in order to use it for both init containers and sidecards

@rokatyy rokatyy marked this pull request as ready for review December 19, 2023 16:02
@rokatyy rokatyy changed the title [Dashboard][Controller] Indroduce init containers [Dashboard][Controller] Introduce init containers Dec 19, 2023
@github-actions github-actions bot added the docs label Dec 19, 2023
TomerShor
TomerShor requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really good!
The container checks are pretty extensive 👌
Added some comments and suggestions below.

pkg/functionconfig/types.go Show resolved Hide resolved
pkg/functionconfig/types.go Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
pkg/platform/kube/test/platform_test.go Outdated Show resolved Hide resolved
pkg/platform/kube/test/platform_test.go Outdated Show resolved Hide resolved
pkg/platform/kube/test/platform_test.go Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
TomerShor
TomerShor approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@TomerShor TomerShor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just really minor stuff regarding naming and such

pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
pkg/platform/kube/functionres/lazy.go Outdated Show resolved Hide resolved
@TomerShor TomerShor changed the title [Dashboard][Controller] Introduce init containers [Deployment] Introduce init containers Dec 21, 2023
@TomerShor TomerShor merged commit 7ad2928 into nuclio:development Dec 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerShor TomerShor TomerShor approved these changes

@liranbg liranbg Awaiting requested review from liranbg

Assignees
No one assigned
Labels
configuration docs platform/kube platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rokatyy @TomerShor