Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helpers] Populate fields from values only if they're empty #3107

Merged
merged 2 commits into from
Jan 3, 2024
Merged

[Helpers] Populate fields from values only if they're empty #3107

merged 2 commits into from
Jan 3, 2024

Conversation

TomerShor
Copy link
Contributor

Check that the field is empty before populating it with the given value, so we won't override the existing value.

liranbg
liranbg requested changes Jan 3, 2024
View reviewed changes
pkg/common/helper.go Show resolved Hide resolved
@TomerShor TomerShor merged commit 4511587 into nuclio:development Jan 3, 2024
11 checks passed
@TomerShor TomerShor deleted the fix-population-helper branch January 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg requested changes

@rokatyy rokatyy rokatyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomerShor @liranbg @rokatyy