Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nuctl] Allow force-deleting resources #3121

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

TomerShor
Copy link
Contributor

@TomerShor TomerShor commented Jan 14, 2024

Allow deleting functions that are in a provisioning state, and projects with resources by using the --force flag.
This is already possible from the API, adding support in nuctl as well.

NOTE: Currently working only on a kubernetes platform.

Resolves #3059

Copy link
Contributor

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Just one suggestion regarding the code. And also, I think it would be good to have a test for this.

pkg/nuctl/command/delete.go Show resolved Hide resolved
@TomerShor
Copy link
Contributor Author

@rokatyy Added a test and resolved the whole namespace issue in nuctl tests 🤓

Copy link
Contributor

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🚀

@TomerShor TomerShor merged commit c594900 into nuclio:development Jan 15, 2024
11 checks passed
@TomerShor TomerShor deleted the issues/3059-nuctl-delete branch January 15, 2024 11:24
@koorukuroo
Copy link

You save me, thx a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot delete a function
3 participants