[Processor] NUC-18 add topic property to event
#3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
reviewed
Jan 17, 2024
There was a problem hiding this comment.
I think we can also implement that for v3iostream event
(pkg/processor/trigger/v3iostream/event.go)
In v3io, the topic is the StreamPath available on the claim.
We will need to populate the v3iostream.Event struct with the stream path as well, and return it in the GetTopic method.
TomerShor
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream triggers use
event.pathas the topic name.This causes some confusion for users, so adding a specific topic property to the event object.
SDK part: nuclio/nuclio-sdk-py#61
Jira - https://jira.iguazeng.com/browse/NUC-18