Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nuctl] Lowercase report fields and report error cause #3126

Merged
merged 4 commits into from
Jan 17, 2024
Merged

[Nuctl] Lowercase report fields and report error cause #3126

merged 4 commits into from
Jan 17, 2024

Conversation

rokatyy
Copy link
Contributor

@rokatyy rokatyy commented Jan 16, 2024

[No ticket]

This PR provides following nuctl import improvements:

  • Save import report with fields in lowercase
  • Print error cause instead of wrapped error
  • Save report for functions as well

@github-actions github-actions bot added the nuctl label Jan 16, 2024
@TomerShor
Copy link
Contributor

@rokatyy looking good!
Can you verify in the existing tests that indeed the correct error is logged in the report?

@rokatyy
Copy link
Contributor Author

rokatyy commented Jan 16, 2024

@TomerShor Done!

@TomerShor TomerShor merged commit 127d68d into nuclio:development Jan 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg approved these changes

@TomerShor TomerShor TomerShor approved these changes

Assignees
No one assigned
Labels
nuctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rokatyy @TomerShor @liranbg