Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Processor] Add a control message to inform the processor that draining is done" #3167

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

TomerShor
Copy link
Contributor

@TomerShor TomerShor commented Feb 15, 2024

Reverts #3153.

We have seen that this new functionality causes issues and is unstable regarding the different handling of the 2 control message kinds:

  • stream ack message is received once by each partition, who always listens for these messages.
  • drain done messages are sent from each partition to every worker, meaning that for N partition and M workers - we will have NxM messages. This requires a much more complex logic to handle, which is risky at this point of the development.

Reverting back to only waiting on timeout until we have a better solution to that.

Resolves https://jira.iguazeng.com/browse/NUC-141

@TomerShor TomerShor merged commit fd3de26 into development Feb 15, 2024
11 checks passed
@TomerShor TomerShor deleted the revert-3153-nuc-124 branch February 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant