Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scripts] Patch - Resolve tag from remote if empty #3201

Merged

Conversation

TomerShor
Copy link
Contributor

If a specific tag is not given for patching, defaulting to some undefined version will cause errors because when building new functions, the dashboard will try to pull onbuild images with the same undefined tag - and will fail.

Instead, if a specific tag is not given we resolve the tag from the version that is currently deployed in the remote system.
This is done by examining the deployment and some awk hacks.

Additionally, did some small cleanups and organized the patch env template.

@TomerShor TomerShor requested a review from quaark March 20, 2024 15:10
@TomerShor TomerShor merged commit d2d9d5b into nuclio:development Mar 21, 2024
11 checks passed
@TomerShor TomerShor deleted the improvement/patch-resolve-tag branch March 21, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant